Refactor "applyLocale" and remove references to "language" column in UFMatch table #18049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes issues raised in this ticket on Lab.
Before
CRM_Core_BAO_ConfigSetting::applyLocale()
does not apply the desired locale wheninheritLocale
is specified.CRM_Core_BAO_ConfigSetting::applyLocale()
reads and saves the locale in the UFMatch table with no discernible use case in doing so.CRM_Admin_Form_Setting_Localization::onChangeLcMessages()
saves the locale in the UFMatch table for the contact/user that saves the setting, again with no discernible effect.After
CRM_Core_BAO_ConfigSetting::applyLocale()
correctly applies the desired locale wheninheritLocale
is specified.CRM_Core_BAO_ConfigSetting::applyLocale()
andCRM_Admin_Form_Setting_Localization::onChangeLcMessages()
no longer touch thelanguage
column in the UFMatch table.Technical Details
See this ticket on Lab for full discussion.
tl;dr This PR fixes a regression where
CRM_Core_BAO_ConfigSetting::applyLocale()
no longer applies the desired locale wheninheritLocale
is specified and removes references to the seemingly-unusedlanguage
column in the UFMatch table.Comments